Updating CMake requirement to 2.8.12 RC 1

Stephen Kelly steveire at gmail.com
Tue Aug 20 20:33:31 UTC 2013


Hello,

CMake 2.8.12 RC 1 was released a few hours ago:

 http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443

Updating to that will allow us to get on the home straight with regard to 
our buildsystem files. 

For example, we can easily set the INTERFACE_INCLUDE_DIRECTORIES of the 
targets we export. We can do that with a simple patch to 
INSTALL_TARGETS_DEFAULT_ARGS in ecm:

  diff --git a/kde-modules/KDEInstallDirs.cmake b/kde-
modules/KDEInstallDirs.cmake
 index c3d4d7c..87370b4 100644
 --- a/kde-modules/KDEInstallDirs.cmake
 +++ b/kde-modules/KDEInstallDirs.cmake
 @@ -173,7 +173,8 @@ _set_fancy(DBUS_SYSTEM_SERVICES_INSTALL_DIR 
"${SHARE_INSTALL_PREFIX}/dbus-1/syst
 # This can then also be used for packaging with cpack.
 set(INSTALL_TARGETS_DEFAULT_ARGS  RUNTIME DESTINATION "${BIN_INSTALL_DIR}"                                                                                                                                        
                             LIBRARY DESTINATION "${LIB_INSTALL_DIR}"                                                                                                                                        
 -                           ARCHIVE DESTINATION "${LIB_INSTALL_DIR}")                                                                                                                      
 +                           ARCHIVE DESTINATION "${LIB_INSTALL_DIR}"                                                                                                                        
 +                           INCLUDES DESTINATION "${INCLUDE_INSTALL_DIR}")                                                                                                                                  
                                                                                                                                                                                                                   

I recommend updating the requirement as below:

 diff --git a/CMakeLists.txt b/CMakeLists.txt
 index 7255a11..30b5fc3 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
 @@ -1,10 +1,10 @@
 
 -set(reqd_cmake 2.8.10.20130411)
 +set(reqd_cmake 2.8.11.20130815)
 if (CMAKE_VERSION VERSION_LESS reqd_cmake)
   message(FATAL_ERROR "
 -  KDE Frameworks requires CMake 2.8.11 RC 3 or later.
 +  KDE Frameworks requires CMake 2.8.12 RC 1 or later.
 
 -  http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/46346
 +  http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/47443


I recommend not updating the requirement again until the final 2.8.12 
release is made, unless there's a sufficiently good reason to do so.

Thanks,

Steve.




More information about the Kde-frameworks-devel mailing list