Review Request 112096: Port KWindowEffects to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112096/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 5:11 p.m.)


Review request for KDE Frameworks and Marco Martin.


Changes
-------

included suggested change.


Description
-------

Basically a rewrite of the X11 implementation of KWindowEffects to XCB. To ensure that it doesn't break I added unit tests for everything except isEffectAvailable (that can hardly be tested as it requires a running KWin).

Please note: this patch is on top of review #112052


Diffs (updated)
-----

  tier1/kwindowsystem/autotests/CMakeLists.txt 5e05c6d 
  tier1/kwindowsystem/autotests/kwindoweffectstest.cpp PRE-CREATION 
  tier1/kwindowsystem/src/kwindoweffects.h bf77e7c 
  tier1/kwindowsystem/src/kwindoweffects_x11.cpp d05ffaf 

Diff: http://git.reviewboard.kde.org/r/112096/diff/


Testing
-------

See new unit tests and test application in kde:scratch/graesslin/kwindoweffectsplugin.git


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/ed0d170b/attachment.html>