Review Request 112052: Split kwindoweffects into an x11 and dummy implementation
Commit Hook
null at kde.org
Mon Aug 19 14:43:00 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/#review38143
-----------------------------------------------------------
This review has been submitted with commit 723d6d37b3286678cfd8b4284da7e7181d249163 by Martin Gräßlin to branch frameworks.
- Commit Hook
On Aug. 13, 2013, 11:53 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112052/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 11:53 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Proper implementation is moved into kwindoweffects_x11.cpp and a
> kwindoweffects_dummy.cpp is provided for Mac and Windows systems.
>
> As every method is X11 specific this makes the code cleaner.
>
>
> Diffs
> -----
>
> tier1/kwindowsystem/src/CMakeLists.txt fe0f920
> tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531
> tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION
> tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112052/diff/
>
>
> Testing
> -------
>
> Compile tested only X11 - cannot test Windows or Mac
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/f2544082/attachment.html>
More information about the Kde-frameworks-devel
mailing list