Review Request 112046: reduce itmeviews test dependency

Commit Hook null at kde.org
Mon Aug 19 10:37:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 10:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
-------

ItemViews use KIconThemes frameworks as test dependency (only for manual test). But KIconThemes have ItemViews as "hard" dependency. Is is easy to remove this "pseudo" circular dependency.
Dependency form CMakeLists.txt will be removed in another review (still in progress)


Diffs
-----

  staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 

Diff: http://git.reviewboard.kde.org/r/112046/diff/


Testing
-------

It builds and tests looks OK (with manual test)


Thanks,

Wojciech Kapuscinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/db2d4015/attachment.html>


More information about the Kde-frameworks-devel mailing list