Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)
Wojciech Kapuscinski
wojtask9.kde at gmail.com
Mon Aug 19 10:27:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112060/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 10:27 a.m.)
Review request for KDE Frameworks.
Description
-------
Everything in staging directory (except kde4support)
Diffs
-----
staging/kemoticons/src/providers/pidgin/CMakeLists.txt 242807d
staging/kemoticons/src/providers/kde/CMakeLists.txt 8602909
staging/kemoticons/src/providers/adium/CMakeLists.txt 2ad9512
staging/kemoticons/src/core/kemoticonstheme.cpp 725c9c1
staging/kemoticons/src/core/CMakeLists.txt de6640b
staging/kemoticons/autotests/CMakeLists.txt b00056a
staging/kde4attic/src/CMakeLists.txt f395cd5
staging/kde4attic/tests/CMakeLists.txt fd7fd3a
staging/kcrash/src/CMakeLists.txt 5bdaf61
staging/kde4attic/autotests/CMakeLists.txt 9e3d488
staging/kconfigwidgets/tests/CMakeLists.txt 919342f
staging/kconfigwidgets/src/CMakeLists.txt 0ec0987
staging/kconfigwidgets/autotests/CMakeLists.txt 3afeccc
staging/kcompletion/tests/CMakeLists.txt 22050fc
staging/kcompletion/src/CMakeLists.txt 9ef378c
staging/kcompletion/autotests/CMakeLists.txt 25fee98
staging/itemviews/tests/CMakeLists.txt 68dd537
staging/itemviews/src/CMakeLists.txt 45b76e1
staging/itemviews/autotests/CMakeLists.txt a122958
staging/frameworkintegration/src/platformtheme/CMakeLists.txt ec20115
staging/frameworkintegration/src/integrationplugin/CMakeLists.txt 437f0e7
experimental/kdeclarative/CMakeLists.txt 6c9b088
staging/kemoticons/src/providers/xmpp/CMakeLists.txt 55330ce
staging/kemoticons/tests/CMakeLists.txt ea7fc0b
staging/kguiaddons/autotests/CMakeLists.txt 772caee
staging/kguiaddons/src/CMakeLists.txt fc8941a
staging/kguiaddons/tests/CMakeLists.txt ab44a37
staging/ki18n/src/CMakeLists.txt f80bae6
staging/kiconthemes/autotests/CMakeLists.txt 854cbe3
staging/kiconthemes/src/CMakeLists.txt 150eb1a
staging/kiconthemes/tests/CMakeLists.txt 49f179c
staging/kinterprocesswindowing/src/CMakeLists.txt 0cb849a
staging/kio/autotests/CMakeLists.txt b43ac26
staging/kio/src/core/CMakeLists.txt be00bbe
staging/kio/src/kssld/CMakeLists.txt f030a65
staging/kio/src/widgets/CMakeLists.txt f68034c
staging/kjobwidgets/autotests/CMakeLists.txt 559ba28
staging/kjobwidgets/src/CMakeLists.txt e160da0
staging/kjobwidgets/tests/CMakeLists.txt 7e5331a
staging/knotifications/autotests/CMakeLists.txt b12bff6
staging/knotifications/tests/CMakeLists.txt 91d46cf
staging/kservice/autotests/CMakeLists.txt 326bbf9
staging/kservice/src/CMakeLists.txt 893f6dd
staging/kservice/tests/CMakeLists.txt 5e94b81
staging/ktextwidgets/autotests/CMakeLists.txt 4c2b9d6
staging/ktextwidgets/src/CMakeLists.txt 1f47da2
staging/ktextwidgets/tests/CMakeLists.txt 3dd1376
staging/kunitconversion/autotests/CMakeLists.txt c041a91
staging/kunitconversion/src/kunitconversion/CMakeLists.txt 3d6771b
staging/kwallet/autotests/CMakeLists.txt 95535ca
staging/kwallet/src/CMakeLists.txt d181426
staging/kwallet/tests/CMakeLists.txt c75ff00
staging/xmlgui/autotests/CMakeLists.txt 6b415ba
staging/xmlgui/src/CMakeLists.txt 9731f98
staging/xmlgui/tests/CMakeLists.txt 3f17e9a
staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 4007776
Diff: http://git.reviewboard.kde.org/r/112060/diff/
Testing
-------
it builds (with prefix removed) and tests looks OK.
Testes with other changes (CMake part1, part2)
Thanks,
Wojciech Kapuscinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/51bb181b/attachment.html>
More information about the Kde-frameworks-devel
mailing list