Review Request 112151: Use components in FindXCB

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 9:39 a.m.)


Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.


Changes
-------

Adding Steve to this review he might be able to provide feedback before Alex is back from vacations.


Description
-------

Instead of finding all or nothing from XCB it becomes components aware. So a user can just specify which XCB components it needs and compilation doesn't fail if a not-needed unrelated component is not found. It also allows to have some components as required and some as optional.


Diffs
-----

  find-modules/FindXCB.cmake 7e7e701 

Diff: http://git.reviewboard.kde.org/r/112151/diff/


Testing
-------

tested in kde-workspace


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/362e32dd/attachment.html>