Review Request 111916: Port khtml_part away from kde_file.h

Vishesh Handa me at vhanda.in
Mon Aug 19 09:32:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 9:32 a.m.)


Review request for KDE Frameworks.


Changes
-------

Use QFileInfo::symLinkTarget() instead of relying on readlink.


Description
-------

 Port khtml_part away from kde_file.h


Diffs (updated)
-----

  khtml/khtml_part.cpp d944a29 

Diff: http://git.reviewboard.kde.org/r/111916/diff/


Testing
-------

Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/bae4b478/attachment.html>


More information about the Kde-frameworks-devel mailing list