Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

[Kevin Ottens]

> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote:
> > Can it maybe even be a QCoreApplication?
> 
> Wojciech Kapuscinski wrote:
>     Probably yes :) Kevin?

Quite some of those tests refer to QIcon and QColor, so QGuiApplication makes more sense.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112051/#review37676
-----------------------------------------------------------


On Aug. 13, 2013, 11:06 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112051/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> port kconfig_compiler from QApplication to QGuiApplication.
> 
> NOTE. This must go before https://git.reviewboard.kde.org/r/111945/ because Qt5::Widgets dependency was removed from kconfig
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/kconfig_compiler/test10main.cpp ca937e4 
>   tier1/kconfig/autotests/kconfig_compiler/test11main.cpp 9d6b12c 
>   tier1/kconfig/autotests/kconfig_compiler/test1main.cpp 229384f 
>   tier1/kconfig/autotests/kconfig_compiler/test2main.cpp dc2714d 
>   tier1/kconfig/autotests/kconfig_compiler/test3amain.cpp b86ee13 
>   tier1/kconfig/autotests/kconfig_compiler/test3main.cpp 3e61573 
>   tier1/kconfig/autotests/kconfig_compiler/test4main.cpp 0de0ec8 
>   tier1/kconfig/autotests/kconfig_compiler/test5main.cpp 4173a31 
>   tier1/kconfig/autotests/kconfig_compiler/test6main.cpp c8a89bb 
>   tier1/kconfig/autotests/kconfig_compiler/test7main.cpp 3fff327 
>   tier1/kconfig/autotests/kconfig_compiler/test8main.cpp e7416e7 
>   tier1/kconfig/autotests/kconfig_compiler/test9main.cpp 5519068 
>   tier1/kconfig/autotests/kconfig_compiler/test_dpointer_main.cpp 4a1320b 
>   tier1/kconfig/autotests/kconfig_compiler/test_signal_main.cpp cce65dc 
> 
> Diff: http://git.reviewboard.kde.org/r/112051/diff/
> 
> 
> Testing
> -------
> 
> It builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/e1f0e0e6/attachment-0001.html>