Review Request 112037: Replace most instances of KFileDialog with QFileDialog

Andrius da Costa Ribas andriusmao at gmail.com
Thu Aug 15 16:37:51 UTC 2013



> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote:
> >

Small question: by replacing KFileDialog by QFileDialog do we still provide the settings to choose whether to use Native or KDE dialog on Windows? I use the KDE one here because of the places panel where I have lots of SFTP/FTP/SMB places defined.


- Andrius da Costa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review37641
-----------------------------------------------------------


On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112037/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 3:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support.
> kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic)	
> Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical.
> 
> With this all uses of KFileDialog are removed, except for KEncodingFileDialog.
> 
> 
> Diffs
> -----
> 
>   kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
>   kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
>   kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
>   kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
>   kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
>   kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
>   kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
>   kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
>   kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
>   kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 
> 
> Diff: http://git.reviewboard.kde.org/r/112037/diff/
> 
> 
> Testing
> -------
> 
> Does not break any tests.
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130815/3e453975/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list