Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109527/#review37815
-----------------------------------------------------------


Shouldn't most if not all the files where you removed the KGlobalSettings use also have the #include directive for the class removed? I see surprisingly none of that.


staging/kde4support/src/kdeui/kfadewidgeteffect.cpp
<http://git.reviewboard.kde.org/r/109527/#comment27999>

    No need to touch kde4support, kglobalsettings will move there anyway.


- Kevin Ottens


On Aug. 13, 2013, 6:33 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109527/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 6:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port to the incoming (hopefully) styleHint SH_Widget_Animate
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kimagefilepreview.cpp a9f3e61 
>   kio/kio/kfileitemdelegate.cpp e0c7d7e 
>   staging/kcompletion/src/klineedit_p.h e318009 
>   staging/kde4support/src/kdeui/kfadewidgeteffect.cpp e182a1b 
>   staging/xmlgui/src/kmainwindow.cpp 2125d84 
>   tier1/kwidgetsaddons/src/kmessagewidget.cpp a4f9975 
> 
> Diff: http://git.reviewboard.kde.org/r/109527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130814/8fd345fa/attachment.html>