Review Request 109526: Implement SH_Widget_Animate in KStyle

Àlex Fiestas afiestas at kde.org
Tue Aug 13 18:07:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109526/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 6:07 p.m.)


Review request for KDE Frameworks.


Changes
-------

Update the patch with correct path


Description
-------

Implement SH_Widget_Animate in KStyle using the configuration we already have in kdeglobal.

I have NOT implemented detailed information about animations because after all this year only NoEffect and SimpleAnimation are used (kglobalsettings.cpp GraphicEffect), so what we want is a YES or NO instead of how much animation is required.

There is NO use of GradientEffects or ComplexAnimationEffects in all kdelibs or kde (grepped 204 repositories in KDE)

Review depends on:
https://codereview.qt-project.org/#change,51166


Diffs (updated)
-----

  staging/frameworkintegration/src/kstyle/kstyle.cpp 375bcac 

Diff: http://git.reviewboard.kde.org/r/109526/diff/


Testing
-------


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/78974433/attachment.html>


More information about the Kde-frameworks-devel mailing list