Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

[Martin Gräßlin]

> On Aug. 13, 2013, 2:01 p.m., Mark Gaiser wrote:
> > Interesting: "Copyright 2009 Marco Martin <notmart at gmail.com>". I think you need to adjust the license part in those new files.

why? The copyright is still correct. Marco has been the one who wrote that code back in 2009. What I just changed is trivial and in my opinion I'm not a copyright holder of these files based on the change.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/#review37681
-----------------------------------------------------------


On Aug. 13, 2013, 1:53 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112052/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Proper implementation is moved into kwindoweffects_x11.cpp and a
> kwindoweffects_dummy.cpp is provided for Mac and Windows systems.
>     
> As every method is X11 specific this makes the code cleaner.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531 
>   tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112052/diff/
> 
> 
> Testing
> -------
> 
> Compile tested only X11 - cannot test Windows or Mac
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/4770f0e7/attachment.html>