Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

Martin Gräßlin mgraesslin at kde.org
Tue Aug 13 11:53:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112052/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Proper implementation is moved into kwindoweffects_x11.cpp and a
kwindoweffects_dummy.cpp is provided for Mac and Windows systems.
    
As every method is X11 specific this makes the code cleaner.


Diffs
-----

  tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
  tier1/kwindowsystem/src/kwindoweffects.cpp 33a4531 
  tier1/kwindowsystem/src/kwindoweffects_dummy.cpp PRE-CREATION 
  tier1/kwindowsystem/src/kwindoweffects_x11.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112052/diff/


Testing
-------

Compile tested only X11 - cannot test Windows or Mac


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/f3c36bff/attachment.html>


More information about the Kde-frameworks-devel mailing list