Review Request 112046: reduce itmeviews test dependency

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112046/#review37661
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Aug. 13, 2013, 9:31 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112046/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 9:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> ItemViews use KIconThemes frameworks as test dependency (only for manual test). But KIconThemes have ItemViews as "hard" dependency. Is is easy to remove this "pseudo" circular dependency.
> Dependency form CMakeLists.txt will be removed in another review (still in progress)
> 
> 
> Diffs
> -----
> 
>   staging/itemviews/tests/kcategorizedviewtest.cpp 8c50f96 
> 
> Diff: http://git.reviewboard.kde.org/r/112046/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests looks OK (with manual test)
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/e6959055/attachment-0001.html>