Review Request 111916: Port khtml_part away from kde_file.h

[Kevin Ottens]

> On Aug. 12, 2013, 2:43 p.m., Kevin Ottens wrote:
> > khtml/khtml_part.cpp, line 3590
> > <http://git.reviewboard.kde.org/r/111916/diff/3/?file=178130#file178130line3590>
> >
> >     For extra safety I'd keep the "ok &&" here.
> 
> David Faure wrote:
>     No, you want to enter this branch for broken symlinks too.

Ah I see. OK then.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37584
-----------------------------------------------------------


On Aug. 12, 2013, 10:15 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 10:15 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> -------
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/209e6020/attachment.html>