Review Request 112037: Replace most instances of KFileDialog with QFileDialog

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review37641
-----------------------------------------------------------



kfile/kdirselectdialog.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27805>

    Hmmm it makes me realize, couldn't KEncodingFileDialog be made to depend on the file module only? That would remove the dependency on KFileDialog (the file module is planned to stay).



kio/kfile/kfiledialog.h
<http://git.reviewboard.kde.org/r/112037/#comment27804>

    Well it's not deprecated, there's legit uses when it comes to extending it...



kio/kfile/kurlrequester.h
<http://git.reviewboard.kde.org/r/112037/#comment27806>

    That obviously breaks the source compatibility, please have it stick to just a QString. It might require some conversion to the QFileDialog format internally of course.



kio/kfile/kurlrequester.h
<http://git.reviewboard.kde.org/r/112037/#comment27807>

    ditto.



kio/kfile/kurlrequester.h
<http://git.reviewboard.kde.org/r/112037/#comment27808>

    We should check if that's used much, if not it's tempting to deprecate that method. Especially when one looks at its description which shows it's useless half of the time. :-)



kio/kfile/kurlrequesterdialog.h
<http://git.reviewboard.kde.org/r/112037/#comment27809>

    If we end up deprecating the one in KUrlRequester, this one will have to be deprecated too.



kio/kssl/kcm/cacertificatespage.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27810>

    We might want to evaluate providing mimetypes as filters to QFileDialog (requires patching QFileDialog... likely a post KF 5.0 task though).



kparts/browserrun.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27814>

    Extra space between parenthesis



kparts/browserrun.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27815>

    ditto



kparts/browserrun.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27812>

    Should not be changed



kparts/browserrun.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27813>

    ditto.



kparts/browserrun.cpp
<http://git.reviewboard.kde.org/r/112037/#comment27811>

    Extra spaces between parenthesis.


- Kevin Ottens


On Aug. 12, 2013, 6:12 p.m., Teo Mrnjavac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112037/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 6:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support.
> kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic)	
> Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical.
> 
> With this all uses of KFileDialog are removed, except for KEncodingFileDialog.
> 
> 
> Diffs
> -----
> 
>   kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
>   kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
>   kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
>   kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
>   kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
>   kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
>   kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
>   kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
>   kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
>   kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 
> 
> Diff: http://git.reviewboard.kde.org/r/112037/diff/
> 
> 
> Testing
> -------
> 
> Does not break any tests.
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/552c4bb8/attachment-0001.html>