Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel
David Faure
faure at kde.org
Mon Aug 12 13:57:38 UTC 2013
> On Aug. 9, 2013, 8:34 p.m., David Faure wrote:
> > The Qt patch is in for some time now, so we can use the new styleHint.
> >
> > However this patch should be updated to pass a pointer to the widget in the styleHint call.
> >
> > Once that's done, we can finally move KGlobalSettings to kde4support (yay!) and kill kdeui for good.
>
> Kevin Ottens wrote:
> Note the patch is in qt/dev but not in qt5.git yet.
Oh I see. The date in the commit (June 17) confused me. That's indeed not the date it got merged in.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109527/#review37451
-----------------------------------------------------------
On March 16, 2013, 7:16 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109527/
> -----------------------------------------------------------
>
> (Updated March 16, 2013, 7:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Port to the incoming (hopefully) styleHint SH_Widget_Animate
>
>
> Diffs
> -----
>
> kdeui/widgets/klineedit.cpp d29296c
> kdeui/widgets/klineedit_p.h 7c58f2d
> kdeui/widgets/kmainwindow.cpp e629454
> kdeui/widgets/kmessagewidget.cpp ce0852f
> kio/kfile/kimagefilepreview.cpp cbd3c43
> kio/kio/kfileitemdelegate.cpp c11d6b6
> staging/kde4support/src/kdeui/kfadewidgeteffect.cpp e182a1b
>
> Diff: http://git.reviewboard.kde.org/r/109527/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130812/4d300fa2/attachment.html>
More information about the Kde-frameworks-devel
mailing list