Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111981/#review37497
-----------------------------------------------------------


I'm kinda confused.

Strigi is still very much required by kde4support/src/kio/kfilemetainfo.cpp. The only reason this compiles is because Strigi is optional, but without it KFileMetaInfo will completely break. Certain application such as localize still depend on it. We cannot break it without offering an alternative.

- Vishesh Handa


On Aug. 9, 2013, 9:32 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111981/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 9:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Follow up to r111897. As said in summary - strigi is not *required* anymore.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3e8e639 
>   cmake/modules-tests/RunAllModuleTests.cmake 1ccce7d 
>   cmake/modules-tests/Strigi/CMakeLists.txt bbe1e23 
>   cmake/modules/CMakeLists.txt 06f5c67 
>   cmake/modules/FindStrigi.cmake bb87b0d 
>   staging/kde4support/CMakeLists.txt c0e81ad 
>   staging/kde4support/src/CMakeLists.txt bebce74 
> 
> Diff: http://git.reviewboard.kde.org/r/111981/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine without strigi.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130811/a52d3240/attachment.html>