Review Request 111981: Mark strigi as optional dependancy

David Faure faure at kde.org
Fri Aug 9 19:55:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111981/#review37449
-----------------------------------------------------------


The right fix is to remove all this stuff from the toplevel CMakeLists.txt (which is going away when we split), and ensure that the subdirs that use strigi (optionally) do have the relevant find_package and set_package_properties on their own.

- David Faure


On Aug. 9, 2013, 6:24 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111981/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Follow up to r111897. As said in summary - strigi is not *required* anymore.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3e8e639 
> 
> Diff: http://git.reviewboard.kde.org/r/111981/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine without strigi.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/8125c658/attachment.html>


More information about the Kde-frameworks-devel mailing list