Review Request 111916: Port khtml_part away from kde_file.h

[David Faure]

> On Aug. 7, 2013, 4:12 p.m., David Faure wrote:
> > This code should be made portable (to Windows), please use QFileInfo.
> 
> Kevin Ottens wrote:
>     As far as I know the QT_* macros would work on windows too. Using QFileInfo would be way nicer though.

Depends on the "*".

win32-msvc2005/qplatformdefs.h:76:#define QT_STAT                     ::_stat
but there's no QT_LSTAT.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37288
-----------------------------------------------------------


On Aug. 6, 2013, 6:14 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 6:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp 189a98e 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> -------
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/585b014f/attachment.html>