Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

[Kai Uwe Broulik]

> On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.cpp, line 65
> > <http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65>
> >
> >     This would be best with use of QLatin1String() thoughout this file. 
> >     
> >

QStringLiteral?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37413
-----------------------------------------------------------


On Aug. 9, 2013, 12:38 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt c913da3 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt 0913349 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/0ba9111a/attachment.html>