Review Request 111877: desktop_to_json cmake macro

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111877/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 10:26 p.m.)


Review request for KDE Frameworks.


Changes
-------

Addressed comments.


Description
-------

This patch adds a macro that allows to convert .desktop files to .json format during build.

#
# desktop_to_json(desktopfile [jsonfile])
#
# This macro uses desktoptojson to compile a json file, from a plugin
# description in a .desktop file. The generated file can be compiled
# into the plugin using the K_PLUGIN_FACTORY_WITH_JSON (cpp) macro.
#
# When jsonFile is omitted, the macro will replace the .desktop file
# extension of the first argument with .json and use that as output.
#
# Examples:
#
#  desktop_to_json(plasma-dataengine-time.desktop)
#
#  desktop_to_json(plasma-dataengine-time.desktop my_output_file.json)
#

With this macro, the desktoptojson programme, the KPluginInfo ctor and the KPluginFactory macros, I can build a Qt-style plugin with minimal changes.


Diffs (updated)
-----

  staging/kservice/CMakeLists.txt 831b963 
  staging/kservice/KServiceConfig.cmake.in a817e41 
  staging/kservice/KServiceMacros.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111877/diff/


Testing
-------

Built different plugins with this macro, they can build a valid KPluginInfo from the plugin metadata. Test is in plasma-framework/src/plasma/tests/kplugin (as it uses DataEngines).


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/e360b15c/attachment.html>