Review Request 111895: Fix Sonnet failing to load its plugins
Commit Hook
null at kde.org
Thu Aug 8 16:19:09 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111895/#review37364
-----------------------------------------------------------
This review has been submitted with commit 143d3b0db3412aebf847b333c1950eae15a3308b by Aurélien Gâteau to branch frameworks.
- Commit Hook
On Aug. 5, 2013, 4:11 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111895/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 4:11 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> This patch change the install path of sonnet plugins to ${PLUGIN_INSTALL_DIR}/sonnet_clients/ instead of ${PLUGIN_INSTALL_DIR}/plugins/sonnet_clients/.
>
> It also fixes loading of plugins to use the full path. It did not work previously because:
>
> a) it was not looking in the correct dir
> b) Loader::loadPlugin() was creating the QPluginLoader with the file name only, ignoring the pathSuffix from Loader::loadPlugins().
>
>
> Diffs
> -----
>
> tier1/sonnet/src/core/loader.cpp 035cf64
> tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1
>
> Diff: http://git.reviewboard.kde.org/r/111895/diff/
>
>
> Testing
> -------
>
> Ran tests/test_suggest with some debug output enabled: it can now find suggestions.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/d3e35688/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list