Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
Kevin Ottens
ervin at kde.org
Thu Aug 8 15:51:37 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37360
-----------------------------------------------------------
Totally makes sense to have that in KConfigGui. Still the issues raised by David E. should be addressed.
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27642>
Should be kconfiggui_export.h since you move it to KConfigGui.
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27643>
Should be KCONFIGGUI
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27644>
Insert an empty line before that one.
- Kevin Ottens
On Aug. 8, 2013, 12:56 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 12:56 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Add KConfigLoader from Plasma Framework to KConfigGui
>
> The ConfigLoader is way to awesome to not be directly in KConfig.
>
>
> Diffs
> -----
>
> tier1/kconfig/autotests/CMakeLists.txt c913da3
> tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION
> tier1/kconfig/src/gui/CMakeLists.txt 0913349
> tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/5f74577a/attachment.html>
More information about the Kde-frameworks-devel
mailing list