Review Request 111942: Return removed config includes from file kioslave
Kevin Ottens
ervin at kde.org
Thu Aug 8 15:44:14 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111942/#review37358
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Aug. 8, 2013, 12:06 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111942/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 12:06 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> While porting away from kde_file.h, the config includes got lost. As they contain some important defines, it should be brought back, otherwise parts of the code will never get executed (like those that have #ifdef HAVE_POSIX_ACL etc).
>
>
> Diffs
> -----
>
> kioslave/file/file.cpp b24d9ae
> kioslave/file/file_unix.cpp db250d0
>
> Diff: http://git.reviewboard.kde.org/r/111942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/1a1d78fc/attachment.html>
More information about the Kde-frameworks-devel
mailing list