Review Request 111906: Update QToolbar's when icon changes

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111906/#review37354
-----------------------------------------------------------



staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp
<http://git.reviewboard.kde.org/r/111906/#comment27636>

    Please put the result of KIconLoader::global()->currentSize(KIconLoader::Toolbar) in a const intermediate variable (this way we avoid calling it twice and it gets more readable).


- Kevin Ottens


On Aug. 6, 2013, 11:13 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111906/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 11:13 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This is the first part of: QToolBar should take its default settings from the global settings when running in a Plasma Workspace session (see loadKDESettings from KToolBar)
> 
> Updates all the QToolbar's in the application when there is a change in the KIconLoader::Toolbar group.
> 
> 
> Diffs
> -----
> 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h edac8db 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp d46b5c8 
> 
> Diff: http://git.reviewboard.kde.org/r/111906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/5d972688/attachment.html>