Review Request 111877: desktop_to_json cmake macro

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111877/#review37351
-----------------------------------------------------------



staging/kservice/KServiceMacros.cmake
<http://git.reviewboard.kde.org/r/111877/#comment27632>

    Should probably be named kservice_desktop_to_json. We prefix those macros with the name of the framework they come from.



staging/kservice/KServiceMacros.cmake
<http://git.reviewboard.kde.org/r/111877/#comment27634>

    please name it target.



staging/kservice/KServiceMacros.cmake
<http://git.reviewboard.kde.org/r/111877/#comment27633>

    Typo, should be ".json" and not "Json" I think.


- Kevin Ottens


On Aug. 4, 2013, 4:07 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111877/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2013, 4:07 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This patch adds a macro that allows to convert .desktop files to .json format during build.
> 
> #
> # desktop_to_json(desktopfile [jsonfile])
> #
> # This macro uses desktoptojson to compile a json file, from a plugin
> # description in a .desktop file. The generated file can be compiled
> # into the plugin using the K_PLUGIN_FACTORY_WITH_JSON (cpp) macro.
> #
> # When jsonFile is omitted, the macro will replace the .desktop file
> # extension of the first argument with .json and use that as output.
> #
> # Examples:
> #
> #  desktop_to_json(plasma-dataengine-time.desktop)
> #
> #  desktop_to_json(plasma-dataengine-time.desktop my_output_file.json)
> #
> 
> With this macro, the desktoptojson programme, the KPluginInfo ctor and the KPluginFactory macros, I can build a Qt-style plugin with minimal changes.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/CMakeLists.txt 831b963 
>   staging/kservice/KServiceConfig.cmake.in a817e41 
>   staging/kservice/KServiceMacros.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111877/diff/
> 
> 
> Testing
> -------
> 
> Built different plugins with this macro, they can build a valid KPluginInfo from the plugin metadata. Test is in plasma-framework/src/plasma/tests/kplugin (as it uses DataEngines).
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/3da0eba4/attachment.html>