Review Request 111897: Move KFileMetaData (and friends) to kde4support
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Aug 8 11:59:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111897/
-----------------------------------------------------------
(Updated Aug. 8, 2013, 11:59 a.m.)
Review request for KDE Frameworks and Vishesh Handa.
Changes
-------
moved some other classes that were only being used by things in kde4support.
Description
-------
As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support.
It's worth noting that there are 2 "plugins" (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp
Diffs (updated)
-----
kio/CMakeLists.txt 89c09ec
kio/kfile/kcommentwidget.cpp f125bc7
kio/kfile/kcommentwidget_p.h
kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d
kio/kfile/kfilemetadataconfigurationwidget.cpp 5fbf8dc
kio/kfile/kfilemetadataprovider.cpp
kio/kfile/kfilemetadataprovider_p.h 8009bf4
kio/kfile/kfilemetadatareader.cpp
kio/kfile/kfilemetadatareader_p.h
kio/kfile/kfilemetadatareaderprocess.cpp
kio/kfile/kfilemetadatawidget.h 2dc4677
kio/kfile/kfilemetadatawidget.cpp 6e0f106
kio/kfile/kmetaprops.h a08c380
kio/kfile/kmetaprops.cpp
kio/kfile/knfotranslator.cpp 64bcecc
kio/kfile/knfotranslator_p.h
kio/kfile/kpreviewprops.h 8a974da
kio/kfile/kpreviewprops.cpp
kio/kfile/kpropertiesdialog.cpp 687e4bf
kio/kio/dummyanalyzers/CMakeLists.txt
kio/kio/dummyanalyzers/dummyanalyzers.cpp
kio/kio/kfilemetainfo.h ddd26d3
kio/kio/kfilemetainfo.cpp a87a8a0
kio/kio/kfilemetainfoitem.h b414274
kio/kio/kfilemetainfoitem.cpp fbaefe0
kio/kio/kfilemetainfoitem_p.h 607ac3e
kio/kio/kfilewrite.desktop
kio/kio/kfilewriteplugin.h
kio/kio/kfilewriteplugin.cpp
kio/kio/kfilewriteplugin_p.h
kio/kio/predicateproperties.h
kio/kio/predicateproperties.cpp
kio/tests/CMakeLists.txt e6deb62
kio/tests/kfilemetainfotest.h
kio/tests/kfilemetainfotest.cpp 74d518b
kio/tests/kmfitest.cpp
kioslave/CMakeLists.txt c16b33e
kioslave/metainfo/CMakeLists.txt a448576
kioslave/metainfo/metainfo.h
kioslave/metainfo/metainfo.cpp
kioslave/metainfo/metainfo.protocol
staging/kde4support/autotests/CMakeLists.txt 22da9ae
staging/kde4support/autotests/kiotesthelper.h PRE-CREATION
staging/kde4support/src/CMakeLists.txt 4ea3497
staging/kde4support/src/config-kde4support.h.cmake 03d3bf4
staging/kde4support/src/kioslave/CMakeLists.txt PRE-CREATION
staging/kde4support/src/kioslave/metainfo/CMakeLists.txt PRE-CREATION
staging/kde4support/tests/CMakeLists.txt 41e35ce
Diff: http://git.reviewboard.kde.org/r/111897/diff/
Testing
-------
builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status?
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130808/50825c7f/attachment.html>
More information about the Kde-frameworks-devel
mailing list