Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

[Martin Klapetek]

> On Aug. 7, 2013, 4:25 p.m., David Faure wrote:
> > Thanks for that review.
> > 
> > So, profiles() and setProfile() are used? For which purpose?

profiles() is used quite extensively in kdepim, it iterates over profiles looking for an email address (aka "is this particular email address among user's email addresses"), see http://lxr.kde.org/source/kde/kdepimlibs/kcal/incidenceformatter.cpp#117 for example.

setProfile() is imho a bit misued, it's used as 

KEMailSettings es;
es.setProfile( es.defaultProfileName() );

however this already happens in constructor. These are the only usages of setProfile() I've found, so I'd be happy to deprecate it as well as it's a bit redundant. I didn't because it breaks quite a lot of code, on the other hand I think that's expected with kf5...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111910/#review37292
-----------------------------------------------------------


On Aug. 6, 2013, 2:30 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111910/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> I've looked through all usages of KEMailSettings on lxr, deprecated things in diff are nowhere used.
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/core/kemailsettings.h 873c222 
>   staging/kio/src/core/kemailsettings.cpp 39dc9f7 
> 
> Diff: http://git.reviewboard.kde.org/r/111910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130807/7f628d7d/attachment.html>