Review Request 111886: Stop using kde_file.h in kdesu
David Faure
faure at kde.org
Wed Aug 7 17:13:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111886/#review37298
-----------------------------------------------------------
Ship it!
just one thing to fix first
kdesu/client.cpp
<http://git.reviewboard.kde.org/r/111886/#comment27598>
QFile::encodeName(d->daemon).constData()
- David Faure
On Aug. 5, 2013, 12:52 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111886/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 12:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Use the actual posix calls instead of the ones in kde_file.h.
>
> The whole class is ifdef'ed to only work with Q_OS_UNIX, so I don't see much point to porting the code to a cross-platform API.
>
>
> Diffs
> -----
>
> kdesu/client.cpp dc81885
> kdesu/process.cpp 645e020
>
> Diff: http://git.reviewboard.kde.org/r/111886/diff/
>
>
> Testing
> -------
>
> builds
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130807/4b19b1c5/attachment.html>
More information about the Kde-frameworks-devel
mailing list