Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/#review37260
-----------------------------------------------------------



tier1/sonnet/src/ui/texteditinstaller.h
<http://git.reviewboard.kde.org/r/111912/#comment27565>

    not sure if you really need that, creating an instance looks simple enough



tier1/sonnet/src/ui/texteditinstaller.cpp
<http://git.reviewboard.kde.org/r/111912/#comment27566>

    how about returning false instead and use that in the event filter to get whatever context menu handling the text edit has configured?


- Kevin Krammer


On Aug. 6, 2013, 4:23 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111912/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 4:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This patch introduces a new class: Sonnet::TextEditInstaller. It makes it easy to add spellcheck support to a QTextEdit.
> 
> Spellcheck support means two things:
> 1. Install Sonnet::Highlighter to highlight spelling error.
> 2. Intercept context menu to replace it with a list of suggestions when user right-clicks on a misspelled word.
> 
> Minimal usage is simple: create a new TextEditInstaller, passing it the QTextEdit as argument. The patch adds a test_textedit executable which demonstrates the class.
> 
> I am posting it early to get feedback on the API and the class name, I am not completely happy with either.
> 
> PS: This patch includes my plugin fixes [1], since it is useless without them.
> [1]: https://git.reviewboard.kde.org/r/111895/
> 
> 
> Diffs
> -----
> 
>   tier1/sonnet/src/core/loader.cpp 035cf64 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1 
>   tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
>   tier1/sonnet/src/ui/highlighter.h c303db1 
>   tier1/sonnet/src/ui/highlighter.cpp e8ba703 
>   tier1/sonnet/src/ui/texteditinstaller.h PRE-CREATION 
>   tier1/sonnet/src/ui/texteditinstaller.cpp PRE-CREATION 
>   tier1/sonnet/tests/CMakeLists.txt 90b3ab0 
>   tier1/sonnet/tests/test_textedit.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111912/diff/
> 
> 
> Testing
> -------
> 
> Tested with test_textedit.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130807/48f1d871/attachment.html>