Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
David Edmundson
david at davidedmundson.co.uk
Tue Aug 6 14:52:16 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------
As a non-Plasma user of this class, I fully support it being here.
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27526>
This looks like it should be const
I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27527>
const?
See above.
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27528>
const?
See above.
- David Edmundson
On Aug. 6, 2013, 12:25 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 12:25 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Description
> -------
>
> Add KConfigLoader from Plasma Framework to KConfigGui
>
> The ConfigLoader is way to awesome to not be directly in KConfig.
>
>
> Diffs
> -----
>
> tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION
> tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130806/c4ee1050/attachment.html>
More information about the Kde-frameworks-devel
mailing list