Review Request 111897: Move KFileMetaData (and friends) to kde4support
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Aug 6 10:13:13 UTC 2013
> On Aug. 6, 2013, 9:39 a.m., Vishesh Handa wrote:
> > You seem to have forgotten about kcommentwidget. It can be discarded/moved as well.
Ok! Will do.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111897/#review37195
-----------------------------------------------------------
On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111897/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 6:06 p.m.)
>
>
> Review request for KDE Frameworks and Vishesh Handa.
>
>
> Description
> -------
>
> As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support.
>
> It's worth noting that there are 2 "plugins" (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp
>
>
> Diffs
> -----
>
> kio/CMakeLists.txt 035cf70
> kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d
> kio/kfile/kfilemetadataconfigurationwidget.cpp
> kio/kfile/kfilemetadataprovider.cpp
> kio/kfile/kfilemetadataprovider_p.h 8009bf4
> kio/kfile/kfilemetadatareader.cpp
> kio/kfile/kfilemetadatareader_p.h
> kio/kfile/kfilemetadatareaderprocess.cpp
> kio/kfile/kfilemetadatawidget.h 2dc4677
> kio/kfile/kfilemetadatawidget.cpp
> kio/kfile/kmetaprops.h a08c380
> kio/kfile/kmetaprops.cpp
> kio/kfile/knfotranslator.cpp
> kio/kfile/knfotranslator_p.h
> kio/kfile/kpreviewprops.h 8a974da
> kio/kfile/kpreviewprops.cpp
> kio/kfile/kpropertiesdialog.cpp 687e4bf
> staging/kde4support/src/CMakeLists.txt 1d6369f
> staging/kde4support/src/config-kde4support.h.cmake 03d3bf4
>
> Diff: http://git.reviewboard.kde.org/r/111897/diff/
>
>
> Testing
> -------
>
> builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status?
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130806/f9c07d81/attachment.html>
More information about the Kde-frameworks-devel
mailing list