Review Request 111897: Move KFileMetaData (and friends) to kde4support

[Aleix Pol Gonzalez]

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote:
> > I was just working on the same thing.
> > 
> > I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets.
> > 
> > Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano.

You were working on it? -.- it didn't have your name on it...

I think that the classes called plugin should be removed, there's not much else to remove otherwise.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111897/#review37193
-----------------------------------------------------------


On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111897/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 6:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Description
> -------
> 
> As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support.
> 
> It's worth noting that there are 2 "plugins" (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp
> 
> 
> Diffs
> -----
> 
>   kio/CMakeLists.txt 035cf70 
>   kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d 
>   kio/kfile/kfilemetadataconfigurationwidget.cpp  
>   kio/kfile/kfilemetadataprovider.cpp  
>   kio/kfile/kfilemetadataprovider_p.h 8009bf4 
>   kio/kfile/kfilemetadatareader.cpp  
>   kio/kfile/kfilemetadatareader_p.h  
>   kio/kfile/kfilemetadatareaderprocess.cpp  
>   kio/kfile/kfilemetadatawidget.h 2dc4677 
>   kio/kfile/kfilemetadatawidget.cpp  
>   kio/kfile/kmetaprops.h a08c380 
>   kio/kfile/kmetaprops.cpp  
>   kio/kfile/knfotranslator.cpp  
>   kio/kfile/knfotranslator_p.h  
>   kio/kfile/kpreviewprops.h 8a974da 
>   kio/kfile/kpreviewprops.cpp  
>   kio/kfile/kpropertiesdialog.cpp 687e4bf 
>   staging/kde4support/src/CMakeLists.txt 1d6369f 
>   staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/111897/diff/
> 
> 
> Testing
> -------
> 
> builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status?
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130806/698df34b/attachment.html>