Review Request 111905: Actually emit iconChanged
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Aug 6 09:56:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111905/#review37197
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 6, 2013, 9:16 a.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111905/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 9:16 a.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Description
> -------
>
> The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does
>
>
> Diffs
> -----
>
> staging/kiconthemes/src/kiconloader.cpp 31e013e
>
> Diff: http://git.reviewboard.kde.org/r/111905/diff/
>
>
> Testing
> -------
>
> Tested it on KdePLatformTheme, it worked nice.
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130806/b2a20c64/attachment.html>
More information about the Kde-frameworks-devel
mailing list