Review Request 111686: KPluginFactory macros port
David Faure
faure at kde.org
Mon Aug 5 23:08:20 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111686/#review37171
-----------------------------------------------------------
Ship it!
staging/kservice/src/plugin/kexportplugin.h
<http://git.reviewboard.kde.org/r/111686/#comment27503>
Hmm, but people were already using K_PLUGIN_FACTORY, right?
So this is more like "K_EXPORT_PLUGIN_is_deprecated_remove_it_and_include_the_moc_file_if_necessary" ? :)
staging/kservice/src/plugin/kpluginfactory.h
<http://git.reviewboard.kde.org/r/111686/#comment27502>
Right. So the name (of the class) really doesn't matter anymore, does it? Oh well.
- David Faure
On Aug. 5, 2013, 10:59 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111686/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 10:59 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> Make K_EXPORT_PLUGIN work with Qt's new plugin system
>
> This patch changes the K_EXPORT_MACRO and the class it generates to be compatible with Qt's new plugin / metadata system. It basically replaces the old macros around q_plugin_instance with the new ones, using Q_INTERFACES. There's also a setter for the args, which are used to pass metadata into the plugin.
>
> Otherwise, this is the minimal change, to make old plugin factories work atop the new framework.
>
> This change is source-compatible, but the right .moc file when this macro is used from the .cpp file.
>
>
> Diffs
> -----
>
> staging/kservice/src/plugin/kexportplugin.h cc5d58b
> staging/kservice/src/plugin/kpluginfactory.h a5ea21b
>
> Diff: http://git.reviewboard.kde.org/r/111686/diff/
>
>
> Testing
> -------
>
> Loaded plugins using KService, KPluginLoader, QPluginLoader and Plasma::PluginLoader, all work as expected.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130805/ca445b28/attachment.html>
More information about the Kde-frameworks-devel
mailing list