Review Request 111895: Fix Sonnet failing to load its plugins

Aurélien Gâteau agateau at kde.org
Mon Aug 5 16:11:09 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111895/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

This patch change the install path of sonnet plugins to ${PLUGIN_INSTALL_DIR}/sonnet_clients/ instead of ${PLUGIN_INSTALL_DIR}/plugins/sonnet_clients/.

It also fixes loading of plugins to use the full path. It did not work previously because:

a) it was not looking in the correct dir
b) Loader::loadPlugin() was creating the QPluginLoader with the file name only, ignoring the pathSuffix from Loader::loadPlugins().


Diffs
-----

  tier1/sonnet/src/core/loader.cpp 035cf64 
  tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1 

Diff: http://git.reviewboard.kde.org/r/111895/diff/


Testing
-------

Ran tests/test_suggest with some debug output enabled: it can now find suggestions.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130805/646bf511/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list