Review Request 111891: Remove <kde_file.h> from kio tests
David Faure
faure at kde.org
Mon Aug 5 16:05:07 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111891/#review37141
-----------------------------------------------------------
Ship it!
Looks good. We'll have to make all this code ifdef Q_OS_UNIX to fix it on Windows anyway, since it's about symlinks.
(But that's easier to test on Windows, so no point in doing it blind on Unix).
- David Faure
On Aug. 5, 2013, 2:16 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111891/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 2:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Removes usages of kde_file.h stuff from kio tests
>
>
> Diffs
> -----
>
> kio/tests/fileundomanagertest.cpp 9e51a21
> kio/tests/jobtest.cpp 786ff53
> kio/tests/kiotesthelper.h 58eac9b
>
> Diff: http://git.reviewboard.kde.org/r/111891/diff/
>
>
> Testing
> -------
>
> Builds and tests have the same results as before.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130805/16fa5dc0/attachment.html>
More information about the Kde-frameworks-devel
mailing list