Review Request 111857: Remove <kde_file.h> from kded.cpp
David Faure
faure at kde.org
Sun Aug 4 11:47:51 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111857/#review37052
-----------------------------------------------------------
kded/kded.cpp
<http://git.reviewboard.kde.org/r/111857/#comment27381>
But we want to get rid of the kdewin dependency.
Looking at kdewin/src/signal.c, kdewin32_signal is basically just signal(), with the proper includes.
So IMHO let's just use the same code everywhere
#ifndef _WIN32_WCE
signal(SIGTERM, sighandler)
#endif
signal(SIGHUP, sighandler)
(and someone will have to add the right includes on Windows)
- David Faure
On Aug. 3, 2013, 1:33 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111857/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2013, 1:33 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Port kded.cpp away from kde_file.h. There was just one usage.
>
>
> Diffs
> -----
>
> kded/kded.cpp cf78607
>
> Diff: http://git.reviewboard.kde.org/r/111857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130804/b06faaa8/attachment.html>
More information about the Kde-frameworks-devel
mailing list