Review Request 111844: Port last use of NetAccess in kio

David Faure faure at kde.org
Sun Aug 4 11:28:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111844/#review37050
-----------------------------------------------------------

Ship it!


Much shorter :-) I like it!

- David Faure


On Aug. 3, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111844/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2013, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Dawit Alemayehu.
> 
> 
> Description
> -------
> 
> Forgot to port this one, it was the complex one to change. Since it needs to gather some data, it uses a helper class that does so, for data and for the final url.
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/widgets/accessmanager.cpp 7120226 
> 
> Diff: http://git.reviewboard.kde.org/r/111844/diff/
> 
> 
> Testing
> -------
> 
> I don't know if there's a test for the access manager...
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130804/85d11fc1/attachment.html>


More information about the Kde-frameworks-devel mailing list