Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

[Sebastian Kügler]

> On Aug. 3, 2013, 10:20 p.m., Milian Wolff wrote:
> > staging/kservice/src/desktoptojson/kconfigtojson.h, line 37
> > <http://git.reviewboard.kde.org/r/111689/diff/9/?file=176099#file176099line37>
> >
> >     why members? that's imo a "verschlimmbesserung". If at all, mark them as static const.

const: d'oh!

static: doesn't work, it asks me to move it outside of the class, which dfaure doesn't like. Otherwise, I'm getting QString::fromUtf8() not allowed there


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review37039
-----------------------------------------------------------


On Aug. 4, 2013, 3:58 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111689/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2013, 3:58 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/src/desktoptojson/CMakeLists.txt PRE-CREATION 
>   staging/kservice/src/desktoptojson/kconfigtojson.h PRE-CREATION 
>   staging/kservice/src/desktoptojson/kconfigtojson.cpp PRE-CREATION 
>   staging/kservice/src/desktoptojson/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111689/diff/
> 
> 
> Testing
> -------
> 
> Converted metadata of several plugins and used them from QPluginLoader -- works.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130804/85a234c0/attachment.html>