Review Request 111844: Port last use of NetAccess in kio

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111844/#review36989
-----------------------------------------------------------


For testing I suppose one would need a webpage with a synchronous XmlHttpRequest. Dawit, do you have an example, based on when you wrote this code?

(One could test by backporting the patch to kdelibs4...)


BTW the next step in my kio splitup is to move this class, that's why I'm pushing for it to not use KIO::NetAccess anymore (so we can deprecate KIO::NetAcess altogether).


staging/kio/src/widgets/accessmanager.cpp
<http://git.reviewboard.kde.org/r/111844/#comment27294>

    The class name could be improved, but let's see what's left after my other suggested changes...



staging/kio/src/widgets/accessmanager.cpp
<http://git.reviewboard.kde.org/r/111844/#comment27293>

    Ah. Using KIO::storedGet instead of KIO::get would take care of this part already, the data collection.
    
    Same for http_post, there's a KIO::storedHttpPost for this.
    
    I think this would simplify the code. No need to connect to data() at all. Hmm, I see that this can even run a KIO::delete synchronously. So some casting will be needed to check if the job is a StoredTransferJob.



staging/kio/src/widgets/accessmanager.cpp
<http://git.reviewboard.kde.org/r/111844/#comment27295>

    Hmm, so all we're missing is an accessor for the redirection url in some job classes? Maybe we could add that. ListJob has it, maybe we could move it up to SimpleJob. And then you wouldn't need this JobInfo at all, right?



staging/kio/src/widgets/accessmanager.cpp
<http://git.reviewboard.kde.org/r/111844/#comment27292>

    Why not just create it on the stack?


- David Faure


On Aug. 2, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111844/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Forgot to port this one, it was the complex one to change. Since it needs to gather some data, it uses a helper class that does so, for data and for the final url.
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/widgets/accessmanager.cpp 7120226 
> 
> Diff: http://git.reviewboard.kde.org/r/111844/diff/
> 
> 
> Testing
> -------
> 
> I don't know if there's a test for the access manager...
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/449de009/attachment.html>