Review Request 111792: XCB event handling for KWindowSystem

[Martin Gräßlin]

> On Aug. 2, 2013, 10:18 a.m., Kevin Ottens wrote:
> > I don't feel like blocking this patch you know much more than me on this topic and I didn't spot anything obviously wrong. :-)
> > 
> > There's a few style issues in the patch (mainly space in between parenthesis), but since this whole module is rather bad for following the style it's minor and will get fixed later.

> There's a few style issues in the patch
I tried to fix as many as possible. At least I run kdevelop's reformat source on the changed code paths. But I agree the whole module needs a proper automatic cleanup.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111792/#review36954
-----------------------------------------------------------


On July 30, 2013, 10:34 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111792/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 10:34 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port KWindowSystemPrivate to QAbstractNativeEventFilter
> 
> Obviously it's only filtering XCB events and the event filtering code
> is ported to use XCB data types.
> 
> With this change the KSystemEventFilter is no longer needed and
> therefore dropped.
> 
> Port NETWinInfo::event from XEvent to xcb_generic_event_t
> 
> Straight forward port just replacing the XLib code by XCB equivalent.
> 
> The logic of looped event compaction is dropped as inspecting the event
> queue is not possible on XCB.
> 
> Port NETRootInfo::event from XEvent to xcb_generic_event_t
> 
> Straight forward port just replacing the XLib functionality to XCB.
> The compaction logic got dropped as it was hard disabled anyway.
> 
> Note: this change currently breaks KWindowSystem as it also needs to
> be ported.
> 
> Coding style cleanup of event handling related methods
> 
> Before adjusting the code let's have a proper coding style.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/CMakeLists.txt PRE-CREATION 
>   tier1/kwindowsystem/src/ksystemeventfilter.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/ksystemeventfilter_p.h PRE-CREATION 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/netwm.h PRE-CREATION 
>   tier1/kwindowsystem/src/netwm.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111792/diff/
> 
> 
> Testing
> -------
> 
> Part of it indirectly tested through KWin on 5. Window caption gets updated and that is triggered through NETWinInfo, so I am positively optimistic that all of it works.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/a2a74169/attachment.html>