Review Request 111834: Move KHelpClient into xmlgui
Kevin Ottens
ervin at kde.org
Fri Aug 2 08:25:42 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111834/#review36956
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Aug. 1, 2013, 3:23 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111834/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 3:23 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> The class still was in kdeui so it had to be moved, after discussing with ervin, it seemed like it's a good place for the function to be.
>
> After all, it's just a helper function, we can always (hope to) instantiate the help using QDesktopServices::openUrl()
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt 5cbcfb0
> staging/xmlgui/src/CMakeLists.txt 255960f
> staging/xmlgui/src/khelpclient.h e5f9946
> staging/xmlgui/src/khelpclient.cpp dda0b13
>
> Diff: http://git.reviewboard.kde.org/r/111834/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130802/991145bd/attachment.html>
More information about the Kde-frameworks-devel
mailing list