Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

[Kevin Krammer]

> On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote:
> > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57
> > <http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57>
> >
> >     Do we want the output/errors to be translated?
> 
> Sebastian Kügler wrote:
>     It's really a helper tool for the build process, so no. I've removed the translations from main.cpp as well.

I see.
I am not expert on CMake, so the questions becomes: is this the right way to ensure it does not end up in /usr/bin or something?
But rather in a place where it can be found by the build system when needed?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36923
-----------------------------------------------------------


On Aug. 1, 2013, 6:03 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111689/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 6:03 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/tools/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION 
>   staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION 
>   staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111689/diff/
> 
> 
> Testing
> -------
> 
> Converted metadata of several plugins and used them from QPluginLoader -- works.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130801/437032a4/attachment.html>