Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

[Sebastian Kügler]

> On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote:
> > Some more nitpicks from my side - sorry Sebas I hope you don't think I'm too pedantic :) But I hope others read this as well and start following the new best-practices for Qt5 codebases.

No problem at all, in fact I much appreciate the thorough review, as indeed this is a good way to transfer knowledge about best practises. :)


> On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote:
> > staging/kservice/tools/desktoptojson/main.cpp, line 20
> > <http://git.reviewboard.kde.org/r/111689/diff/2/?file=175525#file175525line20>
> >
> >     I'm not sure about the style guide in KDELibs, but aren't the <KLocalizedString> kind of includes preferred? Same for the Qt files.

There's no header KLocalizedString, only klocalizedstring.h exists. I'll leave that for now, as it needs addressing elsewhere first.


> On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote:
> > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 26
> > <http://git.reviewboard.kde.org/r/111689/diff/2/?file=175524#file175524line26>
> >
> >     use <QCommandLineParser> or whatever its called, to follow the style of the includes below

There's no CamelCase header for QCommandLineParser. I'll leave it as-is here.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/#review36906
-----------------------------------------------------------


On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111689/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/tools/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION 
>   staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION 
>   staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111689/diff/
> 
> 
> Testing
> -------
> 
> Converted metadata of several plugins and used them from QPluginLoader -- works.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130801/296f23ab/attachment.html>