Review Request 105862: Fix finding the QtMimeTypes headers when compiling frameworks individually
Albert Astals Cid
aacid at kde.org
Wed Apr 10 22:48:50 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105862/#review30890
-----------------------------------------------------------
Patch does not apply anymore. Should it be discarded?
- Albert Astals Cid
On Aug. 5, 2012, 9:28 a.m., George Goldberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105862/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2012, 9:28 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> I hope this is the correct fix - it makes it possible to include files from QtMimeTypes after it has been installed when building individual frameworks standalone, and the includes are still in include/inqt5/QtMimeTypes so I don't think there's any new risk of conflict with Qt upstream instroduced. Is this OK?
>
>
> Diffs
> -----
>
> libinqt5/src/libqtmimetypes/CMakeLists.txt 80b48879d1b52bee02acbdae7bee22b82cb68940
>
> Diff: http://git.reviewboard.kde.org/r/105862/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> George Goldberg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130410/23c03122/attachment.html>
More information about the Kde-frameworks-devel
mailing list