Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.
Jon Severinsson
jon at severinsson.net
Wed Oct 31 16:15:59 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106972/#review21245
-----------------------------------------------------------
Over a week and still no comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!".
- Jon Severinsson
On Oct. 20, 2012, 7:34 p.m., Jon Severinsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106972/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2012, 7:34 p.m.)
>
>
> Review request for KDE Frameworks and Phonon.
>
>
> Description
> -------
>
> This is based on my "Phonon five merge and cleanup" and "Port Phonon five build system to ECM and Qt5Transitional.cmake" patches, and are required for Phonon five to install correctly when built with Qt5.
>
>
> Diffs
> -----
>
> CMakeLists.txt 2b74ba2
>
> Diff: http://git.reviewboard.kde.org/r/106972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jon Severinsson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121031/3502493a/attachment.html>
More information about the Kde-frameworks-devel
mailing list