Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake
Jon Severinsson
jon at severinsson.net
Wed Oct 31 16:15:44 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106970/#review21244
-----------------------------------------------------------
Over a week and still no comments. If no one objects in the next few days, I'm simply gonna push this without any "Ship It!".
- Jon Severinsson
On Oct. 20, 2012, 6:56 p.m., Jon Severinsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106970/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2012, 6:56 p.m.)
>
>
> Review request for KDE Frameworks and Phonon.
>
>
> Description
> -------
>
> This patch is based on my "Phonon five merge and cleanup" patch, and is a step towards building Phonon five on Qt5.
>
> On Qt4 the build system will now insist on "libinqt5" being installed,
> which is located in the kdelibs repository in the frameworks branch.
> There is, however, no dependancy on the actual KDE Frameworks 5, and
> libinqt5 can be build and installed standalone.
>
>
> Diffs
> -----
>
> cmake/FindPhononInternal.cmake 20220a3
> demos/metadatareader/CMakeLists.txt fe6eb60
> demos/phota/CMakeLists.txt 2306c7e
> demos/simplecapture/CMakeLists.txt 4a2e1b0
> demos/simpleplayer/CMakeLists.txt 6824142
>
> Diff: http://git.reviewboard.kde.org/r/106970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jon Severinsson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121031/d84fb9f3/attachment.html>
More information about the Kde-frameworks-devel
mailing list