Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107038/#review20994
-----------------------------------------------------------

Ship it!


Looks good to me.

(Maybe the exported method could be exported "only if building tests" like we do in konqueror, but building tests is on by default nowadays anyway, so this is probably not worth the trouble. So, I said nothing ;) )


kdecore/tests/ktimezonestest.cpp
<http://git.reviewboard.kde.org/r/107038/#comment16494>

    Typo: Defined


- David Faure


On Oct. 26, 2012, 2:53 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107038/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 2:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> If the time zone file for the kconfig configured local time zone does not
> exist in the kconfig configured zoneinfo directory, setLocalZone() would
> set a time zone where isValid() returns true, but all time zone information
> is garbage. This commit changes setLocalZone() to instead set the utc fallback
> time zone as the local time zone.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/ksystemtimezone.cpp aaa10fd 
>   kdecore/tests/ktimezonestest.h 16ba1d0 
>   kdecore/tests/ktimezonestest.cpp 8ea48a4 
> 
> Diff: http://git.reviewboard.kde.org/r/107038/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121027/b29e7edf/attachment.html>